Mladen Turk wrote: > Niklas Therning wrote: >>> >>> It would be great if there is some .indent file because >>> I already noticed that there are some files that are >>> starting to break those rules. >>> >> >> Please have a look here: >> http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention >> >> >> Back when MINA was a sub-project of the directory project we used to >> follow the conventions used by them. > > Huh, but seems this template doesn't follow what's in the SVN. > Not even close. So either it has to be updated so it reflects the > current coding convention or marked as obsolete. > > Regards, > Mladen. >
Right, as I tried to explain we won't reformat files until we actually need to do any changes to them (like fixing a bug or adding a feature). That's why there still are a lot of files which look weird. There are of course tools which take care of these things automatically (like Ctrl+Shift+F in eclipse) but I think we would still need to do a manual audit to make sure things look good after the automatic reformatting. That's one of the reasons why we made this decision IIRC. But maybe it's time to reconsider? It sure would be nice to have all source code fixed before we release 2.0. -- Niklas Therning www.spamdrain.net
