Hi Trustin,

On 5/29/07, Trustin Lee <[EMAIL PROTECTED]> wrote:

Hi Maarten,

On 5/28/07, Maarten Bosteels <[EMAIL PROTECTED]> wrote:
> Hello all,
>
> I created a tutorial on creating a custom ProtocolCodecFilter.
> Please have a look at it and let me know what you think:
>
>
http://cwiki.apache.org/confluence/display/MINA/Tutorial+on+ProtocolCodecFilter

What a great piece of work!  Thank you for your contribution!  It
explains why protocol codec is needed and how it works very clearly.


Thanks !

I don't see any changes needed in the content, but I'd like to point
out a few cosmetic issues:

* Prefer wiki markup to rich text editor, which generates many &nbsp;s.


I started out with rich text editor but quickly switched to wiki markup,
it's definitely easier.

* Use {{...}} expression when referencing a class name (e.g.
{{ProtocolCodecFilter}}).


Will remember that for the next tutorial :-)

* Use our standard coding style.


I thought I did, but apparently I should have read the coding style
document.
I spent some time putting all those opening curly braces on a new line,
because I thought that's how mina code was written :-)

Maarten

I made a change in the latest revision of the tutorial.

Cheers,
Trustin
--
what we call human nature is actually human habit
--
http://gleamynode.net/
--
PGP Key ID: 0x0255ECA6

Reply via email to