On 7/27/07, jian wu <[EMAIL PROTECTED]> wrote:
> Hi,
>
> My arguments to keep messageSent() method are:
>
> 1. It is more flexable to write:
>
>    messageSent( IoFilter.NextFilter nextFilter, IoSession session,
>                 Object message. ) {
>        // some checking logic with sent message, session attributes, ...
>        session.close().join();
>    }
>
>    then:
>      session.write(response).addListener(IoFutureListener.CLOSE);
>
> 2. Both messageSent() and sessionClosed() can be used to do certain
>    management and monitoring operation, including counting, internal
>    state transfering or clean-up, depending on either persistent
>    connection or single request-response based connection.
>
>    Keep both messageSent() and sessionClose() in IoFilter, they can
>    easily share some internal methods/state in one IoFilter class or
>    instance.
>
> My 2 cents.

Sounds like you got my 2 cents. ;)  Let me keep messageSent handler.

Thanks everyone for input!
Trustin
-- 
what we call human nature is actually human habit
--
http://gleamynode.net/
--
PGP Key ID: 0x0255ECA6

Reply via email to