I like Trustin's idea. IMHO better than the static SessionLog, And I don't care about the coupling with SLF4J since MINA already depends on it.
Maarten On 7/27/07, Mark Webb <[EMAIL PROTECTED]> wrote: > > I am thinking that it might be best to keep the two separate. The > separation of the session and slf4j is best IMHO. > > On 7/27/07, 向秦贤 <[EMAIL PROTECTED]> wrote: > > > > hi, > > +1, change to session.getLogger(); > > > > About slf4j, No dout tighty. > > If no use of slf4j, we must do another style log utility, and there are > > only > > options. > > So, go ahead courageously sister:) (topic song of movie <Red Sorghum >) > > > > 2007/7/27, Trustin Lee <[EMAIL PROTECTED]>: > > > > > > Hi community, > > > > > > Sorry for flooding idea, but I got some free time today. :) > > > > > > Currently, we log messages from IoHandler like the following: > > > > > > SessionLog.info(session, "message"); > > > > > > What about integrating this feature into IoSession like the following? > > > > > > // getLogger() returns SLF4J Logger. Category will be the FQCN of the > > > IoHandler. > > > session.getLogger().info(session, "message"); > > > // Category can be overriden if requested. > > > session.getLogger(Main.class).info(session, "message 2"); > > > > > > There won't be any performance difference IMO. > > > > > > I'm not sure it's a good idea to integrate with SLF4J tightly, so > > > please let me know what you think about it. > > > > > > Trustin > > > -- > > > what we call human nature is actually human habit > > > -- > > > http://gleamynode.net/ > > > -- > > > PGP Key ID: 0x0255ECA6 > > > > > > > > > > > -- > > 致敬 > > 向秦贤 > > > > > > -- > ..Cheers > Mark >
