On 7/27/07, Maarten Bosteels <[EMAIL PROTECTED]> wrote: > On 7/27/07, Trustin Lee <[EMAIL PROTECTED]> wrote: > > > > On 7/27/07, Trustin Lee <[EMAIL PROTECTED]> wrote: > > > Hi folks, > > > > > > There are two wrapper classes in trunk for now; ByteBufferProxy and > > > WriteRequestWrapper. One is proxy and the other is wrapper, but I > > > think they don't differ in what they do essentially. Because they are > > > all similar to FilteredInputStream, I thought renaming them to > > > FilteredByteBuffer and FilteredWriteRequest respectively. > > > > > > WDYT? If there's no objection, I will perform the change. > > > > It seems like Servlet API uses 'Wrapper' idiom (i.e. > > HttpServletRequestWrapper) in contrast to FilteredInputStream. > > Wrapper has advantage over Filtered because the classes are listed > > right next to its superclass. > > > > So, I changed my mind to rename ByteBufferProxy to ByteBufferWrapper, > > and retain WriteRequestWrapper. WDYT? > > Ok for me, I think XxxWrapper explains better what it does,
Done. Trustin -- what we call human nature is actually human habit -- http://gleamynode.net/ -- PGP Key ID: 0x0255ECA6
