On 9/17/07, Maarten Bosteels <[EMAIL PROTECTED]> wrote: > Hi Trustin, > > On 9/17/07, Trustin Lee <[EMAIL PROTECTED]> wrote: > > > > Hi Maaretn, > > > > On 9/17/07, Maarten Bosteels <[EMAIL PROTECTED]> wrote: > > > I fixed a possible ConcurrentModificationException in the test-case. > > > I hope that was the failure you saw ? > > > > I didn't actually check the cause. :) > > > > > I have run the test-case several times both on linux and Windows XP, and > > it > > > always succeeded. > > > > It passes very well now, but why does this test case take up a lot of > > CPU and take more than 10 seconds to run? Somewhat odd... > > > On my 2.3 Ghz dual core Windows box it "only" takes 6,655 seconds :-) > And on a 3Ghz single-core Xeon linux box, it takes 12 seconds. > Didn't know dual core would make such a difference. > > Yes, it's one of the slowest tests in mina, I don't really know why. > > Each of the 6 test-methods starts a SocketAcceptor and makes 2 connections. > Although the filter itself is pretty simple, I wanted to test this filter > with a real > SocketAcceptor and a real ExecutorFilter etc. > > If you have any suggestions to make it speedier, please let me know. I'll be > glad to fix it. > Maybe I could re-use the acceptor for all test-methods and just replace the > filter-chain > but that seems a bit messy. > > BTW, do we have to manually set the svn properties for every file we add to > subversion ? > Can't we use default properties on all .java files ?
You mean keyword substitution? The following article might be helpful: http://blog.gleamynode.net/2006/12/setting-svnkeyword-property.html HTH, Trustin -- what we call human nature is actually human habit -- http://gleamynode.net/ -- PGP Key ID: 0x0255ECA6
