I renamed to CommentEventFilter. Looking at all utility filters in org.apache.mina.filter.util, all of them dropped the 'Io' prefix. So did I.
I hope this doesn't dismay anyone. ;) Cheers, Trustin On 11/8/07, Mark <[EMAIL PROTECTED]> wrote: > +1 CommonEventIoFilter > > On Nov 7, 2007 10:49 AM, Maarten Bosteels <[EMAIL PROTECTED]> wrote: > > yes, you're right. After hitting the send button, I was having second > > thoughts. > > > > CommonEventIoFilter is fine for me, sorry for creating confusion :-) > > > > > > > > On Nov 7, 2007 4:40 PM, Jeroen Brattinga <[EMAIL PROTECTED]> wrote: > > > > > In that case CommonEventIoFilter is a better option, IMO. > > > > > > (I don't get the 'combining' part in the EventCombiningIoFilter, since > > > there really is no combine action involved). > > > > > > > > > Jeroen Brattinga > > > > > > > > > On Wed, 2007-11-07 at 10:18 +0100, Maarten Bosteels wrote: > > > > yes, that's better than what we had until now > > > > I change my vote :-) > > > > > > > > +1 EventCombiningIoFilter > > > > > > > > Thanks, > > > > Maarten > > > > > > > > On Nov 7, 2007 10:11 AM, Eero Nevalainen <[EMAIL PROTECTED]> > > > > wrote: > > > > > > > > > I think it'd be nicer to have something that ends with IoFilter. > > > > > So one more shot at naming the bugger: > > > > > > > > > > EventCombiningIoFilter > > > > > > > > > > -Eero > > > > > > > > > > Mike Heath wrote: > > > > > > +1 CommonIoEventFilter > > > > > > > > > > > > It seams like there may be a better name for this but > > > > > > CommonIoEventFilter would be fine. > > > > > > > > > > > > -Mike > > > > > > > > > > > > Maarten Bosteels wrote: > > > > > >> It's hard to come up with a good name for this beast, I'd welcome > > > all > > > > > new > > > > > >> suggestions :-) > > > > > >> For now, this is my vote: > > > > > >> > > > > > >> +1 CommonIoEventFilter > > > > > >> > > > > > >> Maarten > > > > > >> > > > > > >> On 11/6/07, Trustin Lee <[EMAIL PROTECTED]> wrote: > > > > > >>> Hi folks, > > > > > >>> > > > > > >>> WrappingFilter is a new utility abstract IoFilter for those who > > > want > > > > > >>> to filter all events in a single filter method: > > > > > >>> > > > > > >>> > > > > > >>> > > > > > > > > http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/util/WrappingFilter.java?view=markup > > > > > >>> > > > > > >>> One known usage is here: > > > > > >>> > > > > > >>> > > > > > >>> > > > > > > > > http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/logging/MdcInjectionFilter.java?view=markup > > > > > >>> > > > > > >>> However, WrappingFilter doesn't represent what it does exactly, so > > > we > > > > > >>> need a new name. So far, the following names were suggested: > > > > > >>> > > > > > >>> * GenericIoFilter > > > > > >>> * SameActionForEveryIoEventTypeFilter > > > > > >>> * CommonIoEventFilter > > > > > >>> * SingletonActionIoFilter > > > > > >>> * MuxingIoFilter - (see http://en.wikipedia.org/wiki/Multiplexing) > > > > > >>> * CrossCuttingIoFilter - (see > > > > > >>> http://en.wikipedia.org/wiki/Cross-cutting_concern) > > > > > >>> > > > > > >>> Please feel free to add your suggestion or to cast a vote. I'd > > > like > > > > > >>> to see some consensus anyway. > > > > > >>> > > > > > >>> Trustin > > > > > >>> -- > > > > > >>> what we call human nature is actually human habit > > > > > >>> -- > > > > > >>> http://gleamynode.net/ > > > > > >>> -- > > > > > >>> PGP Key ID: 0x0255ECA6 > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > -------------------------------- > The adjuration to be "normal" seems shockingly repellent to me; I see > neither hope nor comfort in sinking to that low level. I think it is > ignorance that makes people think of abnormality only with horror and > allows them to remain undismayed at the proximity of "normal" to > average and mediocre. For surely anyone who achieves anything is, > essentially, abnormal. > Dr. Karl Menninger > -- what we call human nature is actually human habit -- http://gleamynode.net/ -- PGP Key ID: 0x0255ECA6
