Other than I typo in the javadoc (I just checked in the fix), all looks good. I know this is not possible in the interface, but if the IllegalArgumentException could say how to fix this it would probably save us some support time. What I am thinking for instance is something like what AbstractIoSession.write() says when the buffer is not flipped.
On Nov 13, 2007 6:07 AM, Trustin Lee <[EMAIL PROTECTED]> wrote: > Hi community, > > I've just finished implementation of IoSession.read() and ReadFuture. > The following example is a simple telnet client. (the port number in > the source code is the FTP port though.) > > * > https://issues.apache.org/jira/secure/attachment/12369420/ReadFutureTest.java > > The following is the URL of the related JIRA issue raised by Brad, the > original author of the patch: > > * https://issues.apache.org/jira/browse/DIRMINA-375 > > Please also review JavaDoc of IoSession.read(): > > http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/common/IoSession.java?view=markup > > Now 4 issues to go.... > > Cheers, > Trustin > -- > what we call human nature is actually human habit > -- > http://gleamynode.net/ > -- > PGP Key ID: 0x0255ECA6 > -- -------------------------------- The adjuration to be "normal" seems shockingly repellent to me; I see neither hope nor comfort in sinking to that low level. I think it is ignorance that makes people think of abnormality only with horror and allows them to remain undismayed at the proximity of "normal" to average and mediocre. For surely anyone who achieves anything is, essentially, abnormal. Dr. Karl Menninger
