[
https://issues.apache.org/jira/browse/DIRMINA-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542949
]
Mark Webb commented on DIRMINA-478:
-----------------------------------
I have only been looking at the code since I posted my previous message, but I
would say that this code will require some changes. Like you say, the first
thing I noticed was that he is using byte arrays and I think IoBuffers would be
better suited for this. I will keep investigating, but not sure about this
yet.
Another note is that Matt actually wrote this as a CodecFactory and not an
IoFilter.
It would be my opinion that we keep only the CompressionFilter. Not sure we
need a second manner in which to compress/decompress data in MINA.
..my 2 cents
> GzipFilter
> ----------
>
> Key: DIRMINA-478
> URL: https://issues.apache.org/jira/browse/DIRMINA-478
> Project: MINA
> Issue Type: New Feature
> Components: Filter
> Affects Versions: 1.1.4
> Reporter: Matthew Giedt
> Priority: Trivial
> Attachments: gzip.zip.rename
>
>
> Hi Matt,
> On Nov 14, 2007 4:47 AM, mgiedt <[EMAIL PROTECTED]> wrote:
> >
> > I did some poking around and couldn't find a protocol handler for GZip so I
> > created this one. Would very much welcome the communities feedback; MINA
> > team the code is yours to do whatever you wish. (rename the file to
> > 'gzip.zip', bob's your uncle.)
> Thank you very much for your contribution first of all! :D
> However, would you mind if you can create a JIRA issue and attach that
> file there? You have to grant license to the ASF for your work
> (gzip.zip) when you attach a file. I know it's pain in the butt, but
> that's the way how legal stuff works.
> Thanks in advance and best regards,
> Trustin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
