Hi Niklas, I forgot to your reply and please forgive my another too late reply. :)
Yeah, I am suggesting to remove ReadThrottleFilter, WriteThrottleFilter and TrafficShapingFilter. Consequently all classes under org.apache.mina.filter.traffic should be removed. Of course, MINA provides an alternative way to prevent OOM. If you take a look into org.apache.mina.filter.executor package, you will find IoEventQueueThrottle which implements IoEventQueueHandler. You can prevent OOM by specifying proper IoEventQueueThrottle when you construct Ordered/UnorderedThreadPoolExecutor. Let me wait for another 3 days and move the org.apache.mina.filter.traffic to sandbox until someone makes it work correctly. For now, it's full of inefficiency and bugs. Thanks, Niklas Gustavsson wrote: > Just so that I fully understand the proposal. The stuff you want to > remove are the ReadThrottleFilter and WriteThrottleFilter and > associated classes? Would you like them removed for 2.0 due to them > not being sufficiently mature and then bring them back later as they > get better. Or do you want them removed for good? > > Given that there has been some questions here on this topic (people > getting OOM exceptions), some type of recommendation/solution should > be provided, right? Documentation that explains how to do it in the OS > IP stack would be fine for me. > > Or I might be misunderstanding your proposal completly :-) > > /niklas > > On Mon, Mar 17, 2008 at 11:31 AM, 이희승 (Trustin Lee) <[EMAIL PROTECTED]> wrote: >> Hi, >> >> I'd like to propose to drop the current traffic throttling filters from >> 2.0. The reasoning behind this proposal is: >> >> 1) Traffic throttling is very difficult to implement - our implementation >> seems to be buggy. >> 2) Most operating systems already provide QoS stack. >> >> Of course, this doesn't mean we have to drop existing overload prevention >> mechanism included in OrderedThreadPoolExecutor and >> UnorderedThreadPoolExecutor. >> >> WDYT? >> >> -- >> Trustin Lee - Principal Software Engineer, JBoss, Red Hat >> -- >> what we call human nature is actually human habit >> -- >> http://gleamynode.net/ >> -- Trustin Lee - Principal Software Engineer, JBoss, Red Hat -- what we call human nature is actually human habit -- http://gleamynode.net/
signature.asc
Description: OpenPGP digital signature
