Hi Trustin Wow, very comprehensive. I hope you wrote a code generator to write that doc! :-)
Here's some feedback on the javadoc. I know you asked for feedback on the original interface, so apologies if some of this is a bit late. 1. In the doc for removeSlice(int) it currently says *This method differs from removeSlice(int).* Should that be *This method differs from pollSlice() *? 2. Instead of elementAsXxx(int index), how about getXxxAt(int index), or something like that. To me, *elementAs* suggests that an element of the Queue (i.e. a ByteBuffer) is being retrieved and converted to a different type, when really we're getting a value from the bytes *within* a ByteBuffer and converting it. Maybe I'm just being a bit pedantic about that one. 3. Do you think it's worth adding a version of Collection.add() for primitive types. i.e. a method that throws an exception if the primitive can't be added? I can imagine that in a lot of cases it will be tiresome to always check the return value of the offer methods to see if an operation failed. Cheers Rich On Thu, May 22, 2008 at 2:45 PM, 이희승 (Trustin Lee) <[EMAIL PROTECTED]> wrote: > Hi folks, > > I've just added JavaDoc to the classes in org.apache.mina.queue package to > make sure we understood the semantic of all operations correctly: > > * > http://svn.apache.org/viewvc/mina/branches/buffer/core/src/main/java/org/apache/mina/queue/ > > A little bit of documentation was copied from Rich's patch. Please review. > I will start implementation.. > > Cheers, > -- > Trustin Lee - Principal Software Engineer, JBoss, Red Hat > > -- Rich Dougherty http://www.richdougherty.com/
