[
https://issues.apache.org/jira/browse/DIRMINA-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610344#action_12610344
]
Julien Vermillard commented on DIRMINA-415:
-------------------------------------------
First comments : formatting is wrong you can get our formatting rules for
eclipse here :
http://mina.apache.org/developer-guide.data/ImprovedJavaConventions.xml
No tabs, 4 whitespaces in place.
you don't need to add
if (logger.isDebugEnabled()) {
Because slf4j will do string concatenation only when the log level is suffisant.
Anyway, nice contribution !! I'll try to say more as soon I can run it.
> Proxy support
> -------------
>
> Key: DIRMINA-415
> URL: https://issues.apache.org/jira/browse/DIRMINA-415
> Project: MINA
> Issue Type: New Feature
> Components: Transport
> Reporter: Trustin Lee
> Fix For: 2.0.0-M2
>
> Attachments: mina-connector-proxy-1.1.0-mina2.zip,
> mina-connector-proxy-1.1.0.zip, minaproxy-2.0.0-M1.zip
>
>
> There has been enourmous demand for supporting proxy such as simple port
> forwarding and SOCKS. We need to investigate what the best way is to provide
> an extension point for proxies.
> IoFilters are not adequate for proxies because proxies needs changes in the
> socket addresses (both local and remote) of IoSession.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
