On Mon, Jul 7, 2008 at 9:43 PM, Adam Fisk <[EMAIL PROTECTED]> wrote:
> That said, it's most importantly not a big issue and should be barely
> visible on the priority list. Getting 2.0 out the door should be the
> overarching focus of MINA right now, and things like this distract
> from that. I know it's always tempting to tweak code to one's liking
> as you make your way through it, but it's an important temptation to
> resist!
While I wholeheartedly agree, I think the issue that Emmanuel brought
up with the ExceptionMonitor catching also Errors should be corrected.
How about making the following change:
Index: core/src/main/java/org/apache/mina/core/DefaultExceptionMonitor.java
===================================================================
--- core/src/main/java/org/apache/mina/core/DefaultExceptionMonitor.java
(revision
674647)
+++ core/src/main/java/org/apache/mina/core/DefaultExceptionMonitor.java
(working
copy)
@@ -39,7 +39,9 @@
@Override
public void exceptionCaught(Throwable cause) {
- if (log.isWarnEnabled()) {
+ if (cause instanceof Error) {
+ throw (Error) cause;
+ } else {
log.warn("Unexpected exception.", cause);
}
}
/niklas
