[
https://issues.apache.org/jira/browse/FTPSERVER-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niklas Gustavsson closed FTPSERVER-141.
---------------------------------------
Resolution: Fixed
Fixed, I also added a test for configuration of the DbUserManager and found two
additional bugs. All fixed in:
svn commit "/media/big/home/svn/apache/ftpserver-trunk/core" -m "Fixing various
issues with configuration of DbUserManager (FTPSERVER-141 and further issues).
Thanks Peter!" --username "ngn"
M
/media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java
M
/media/big/home/svn/apache/ftpserver-trunk/core/src/main/resources/org/apache/ftpserver/config/spring/ftpserver-1.0.xsd
A
/media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/XmlDbUserManagerConfigTest.java
A
/media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-db-user-manager.xml
Transmitting file data:
/media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/DbUserManager.java
Transmitting file data:
/media/big/home/svn/apache/ftpserver-trunk/core/src/main/resources/org/apache/ftpserver/config/spring/ftpserver-1.0.xsd
Transmitting file data:
/media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/XmlDbUserManagerConfigTest.java
Transmitting file data:
/media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-db-user-manager.xml
Committed revision 680961
> sql statements expected in <statements> tag by xsd but code searches directly
> in <db-user-manager>
> --------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-141
> URL: https://issues.apache.org/jira/browse/FTPSERVER-141
> Project: FtpServer
> Issue Type: Bug
> Components: Core
> Reporter: Peter van der Velde
> Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The ftpserver-1.0.xsd wants the sql statements in an sub node called
> statements:
> <!-- Element used to configure a database based user manager -->
> <xs:element name="db-user-manager">
> <xs:complexType>
> <xs:sequence>
> <xs:element name="data-source"
> type="spring-bean-or-ref"/>
> <xs:element name="statements">
> <xs:complexType>
> <xs:sequence>
> <xs:element
> name="insert-user" type="xs:string"/>
> <xs:element
> name="update-user" type="xs:string"/>
> <xs:element
> name="delete-user" type="xs:string"/>
> <xs:element
> name="select-user" type="xs:string"/>
> <xs:element
> name="select-all-users" type="xs:string"/>
> <xs:element
> name="is-admin" type="xs:string"/>
> <xs:element
> name="authenticate" type="xs:string"/>
> </xs:sequence>
> </xs:complexType>
> </xs:element>
> </xs:sequence>
> </xs:complexType>
> </xs:element>
> But the code in UserManagerBeanDefinitionParser.java:
> protected void doParse(Element element, ParserContext parserContext,
> BeanDefinitionBuilder builder) {
> ...
> Element dsElm = SpringUtil.getChildElement(element,
> FtpServerNamespaceHandler.FTPSERVER_NS, "data-source");
> ...
> builder.addPropertyValue("sqlUserInsert", getSql(element,
> "insert-user"));
> element is the db-user-manager node which does not contain the insert-user
> node(according to the xsd).
> The example on the website does not have the statements tag.
> So either the xsd is wrong or the code....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
