Re: svn commit: r685389 [4/4] - in /mina/trunk/core/src/main/java/org/apache/mina/proxy: ./ event/ filter/ handlers/ handlers/http/ handlers/http/basic/ handlers/http/digest/ handlers/http/ntlm/ handlers/socks/ session/ utils/

[Emmanuel Lecharny]

Julien Vermillard wrote:
Sorry but -1 here, the headers and authors tags are wrong and javadoc
is not clear and not on all the parameters (copyDirective)
and at the end of file you even have  javadoc less public methods.
  
Choppé par les keufs ! :)
Ok, the @author tags should contains a ref to the mina dev list. It has 
been decided years ago. This is not a common Apache rule, but many 
projects do so. (And it's good not to receive mails from people using 
your code years after it has been committed :)

Julien, is there something else in the header which need to be fixed ?

(About the missing javadoc for public method, it might just have gone 
through the radar).

Thanks Julien for the review ! (And thanks Edouard for the big commit !)

--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org