Hi, In fact neither AbstractConnectorTest.java, neither it's childs use Executors so i think it's a monothread task. In that case StringBuilder won't harm but while thinking at it, it may be safer to keep using a StringBuffer in this class in case it's used in a multi thread env. wdyt ?
Cordialement, Regards, -Edouard De Oliveira- http://tedorg.free.fr/en/main.php ----- Message d'origine ---- De : Emmanuel Lecharny <[EMAIL PROTECTED]> À : [email protected] Envoyé le : Dimanche, 17 Août 2008, 16h07mn 37s Objet : Re: svn commit: r686611 - /mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java Hi, are you sure this is thread safe ( StringBuilder is _not_ synchronized ) ? (just checking :) [EMAIL PROTECTED] wrote: > Author: edeoliveira > Date: Sun Aug 17 06:33:27 2008 > New Revision: 686611 > > URL: http://svn.apache.org/viewvc?rev=686611&view=rev > Log: > Reformatted and substituted StringBuffer by StringBuilder > > Modified: > >mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java > > Modified: > mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java > URL: > http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java?rev=686611&r1=686610&r2=686611&view=diff > ============================================================================== > --- > mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java > (original) > +++ > mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractConnectorTest.java > Sun Aug 17 06:33:27 2008 > @@ -54,7 +54,7 @@ > acceptor.bind(new InetSocketAddress(port)); > > try { > - final StringBuffer buf = new StringBuffer(); > + final StringBuilder buf = new StringBuilder(); > IoConnector connector = createConnector(); > connector.setHandler(new IoHandlerAdapter() { > @Override > @@ -87,7 +87,7 @@ > > public void testConnectFutureFailureTiming() throws Exception { > int port = AvailablePortFinder.getNextAvailable(3025); > - final StringBuffer buf = new StringBuffer(); > + final StringBuilder buf = new StringBuilder(); > > IoConnector connector = createConnector(); > connector.setHandler(new IoHandlerAdapter() { > > > > -- -- cordialement, regards, Emmanuel Lécharny www.iktek.com directory.apache.org _____________________________________________________________________________ Envoyez avec Yahoo! Mail. Une boite mail plus intelligente http://mail.yahoo.fr
