[ 
https://issues.apache.org/jira/browse/FTPSERVER-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niklas Gustavsson closed FTPSERVER-165.
---------------------------------------

    Resolution: Fixed
      Assignee: Niklas Gustavsson

Patches applied, and I added in a test as well. Thanks!

svn commit 
"/media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/config/spring/FileSystemBeanDefinitionParser.java"
 
"/media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-1.xml"
 
"/media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/SpringConfigTest.java"
 -m "FileSystemBeanDefinitionParser tries to set the property "create-home" 
instead of createHome (FTPSERVER-165)" --username "ngn"
        M 
/media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/config/spring/FileSystemBeanDefinitionParser.java
        M 
/media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/SpringConfigTest.java
        M 
/media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-1.xml
          Transmitting file data: 
/media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/config/spring/FileSystemBeanDefinitionParser.java
          Transmitting file data: 
/media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/SpringConfigTest.java
          Transmitting file data: 
/media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-1.xml
Committed revision 687013

> FileSystemBeanDefinitionParser tries to set the property "create-home" 
> instead of createHome.
> ---------------------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-165
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-165
>             Project: FtpServer
>          Issue Type: Bug
>    Affects Versions: 1.0-M2, 1.0-M3
>            Reporter: David Latorre
>            Assignee: Niklas Gustavsson
>            Priority: Minor
>             Fix For: 1.0-M3, 1.0-M2
>
>         Attachments: config-spring-xml.patch, createHomePatch.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> Current code is : 
>  builder.addPropertyValue("create-home", Boolean
>                     .parseBoolean(element.getAttribute("create-home")));
> but it should be:
>             builder.addPropertyValue("createHome", Boolean
>                     .parseBoolean(element.getAttribute("create-home"))); 
> Besides, the  xml file used in the tests has no create-home property so the 
> bug remained unnoticed in the tests. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to