Edouard De Oliveira wrote:
Am i too tired or is there something wrong in the log methods ?
if (eventLevel == LogLevel.TRACE) {
logger.trace(message, cause);
} else if (eventLevel.getLevel() > LogLevel.INFO.getLevel()) {
logger.info(message, cause);
} else if (eventLevel.getLevel() > LogLevel.WARN.getLevel()) {
logger.trace(message, cause);
} else if (eventLevel.getLevel() > LogLevel.ERROR.getLevel()) {
logger.warn(message, cause);
} else if (eventLevel.getLevel() > LogLevel.NONE.getLevel()) {
logger.error(message, cause);
}
Why use > instead of simple == ?
Because if the logger level is INFO, and the event level is TRACE, using
== won't gives you any log. (remember that we have 2 different log level
: the underlying log level -log4j for instance- and the event log level.)
In case of LogLevel.NONE there should be no log.
In case of LogLevel.ERROR the method call should be logger.error(...)
etc ...
Did you copy/pasted too fast ? :)
Nope. But the problem is that, as explain in the previous comment, we
are trying to override the logger level by using an event log level. I
think this is a problem.
More than that, the availibility of this LogFilter in Core is
questionable. I would rather put it in a tutorial, or in some Tools
subproject, as it's really, as you say, a debugging tool.
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
