[
https://issues.apache.org/jira/browse/DIRMINA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635928#action_12635928
]
Edwin Lee commented on DIRMINA-626:
-----------------------------------
Proposed changes for
org.apache.mina.transport.serial.DefaultSerialSessionConfig.
### Eclipse Workspace Patch 1.0
#P mina-transport-serial
Index:
src/main/java/org/apache/mina/transport/serial/DefaultSerialSessionConfig.java
===================================================================
---
src/main/java/org/apache/mina/transport/serial/DefaultSerialSessionConfig.java
(revision 700650)
+++
src/main/java/org/apache/mina/transport/serial/DefaultSerialSessionConfig.java
(working copy)
@@ -19,7 +19,6 @@
*/
package org.apache.mina.transport.serial;
-import org.apache.mina.core.session.AbstractIoSessionConfig;
import org.apache.mina.core.session.IoSessionConfig;
/**
@@ -28,7 +27,7 @@
* @author The Apache MINA Project ([email protected])
* @version $Rev: 529576 $, $Date: 2007-04-17 14:25:07 +0200 (mar., 17 avr.
2007) $
*/
-class DefaultSerialSessionConfig extends AbstractIoSessionConfig implements
+class DefaultSerialSessionConfig extends AbstractSerialSessionConfig implements
SerialSessionConfig {
private int receiveThreshold = -1;
> Compilation Error in
> org.apache.mina.transport.serial.DefaultSerialSessionConfig
> --------------------------------------------------------------------------------
>
> Key: DIRMINA-626
> URL: https://issues.apache.org/jira/browse/DIRMINA-626
> Project: MINA
> Issue Type: Bug
> Components: Transport
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Reporter: Edwin Lee
> Priority: Blocker
> Fix For: 2.0.0-M4, 2.0.0-RC1
>
> Attachments: AbstractSerialSessionConfig.java
>
>
> The public accessor/mutator methods in
> org.apache.mina.transport.serial.DefaultSerialSessionConfig are annotated
> with @Override, but its superclass
> (org.apache.mina.core.session.AbstractIoSessionConfig) does not have those
> methods declared.
> Propose to:
> 1. Add a new abstract class
> org.apache.mina.transport.serial.AbstractSerialSessionConfig which extends
> org.apache.mina.core.session.AbstractIoSessionConfig and implements
> org.apache.mina.transport.serial.SerialSessionConfig.
> 2. The new abstract class declares the methods which
> org.apache.mina.transport.serial.DefaultSerialSessionConfig @OverrideS.
> 3. org.apache.mina.transport.serial.DefaultSerialSessionConfig extends
> org.apache.mina.transport.serial.AbstractSerialSessionConfig instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
