Andy Thomson wrote:
Andrea,
This makes sense if the base file systems is/are a real file system.
The Native File System being such a case.
The only sense that I see in appending 'Object' to an class name is the
need to not clash with java.io.File. They are all objects, there is not
need to restating this.
The change from FileObject -> FtpFile was not done by me but it is
welcome by me.
In my opinion, I would leave the FileObject as-is,
My patch is not about renaming FileObject to FtpFile, this was already
done by in the 701234 commit by ngn.
Revision: 701234
Author: ngn
Date: 22.28.16, giovedì 2 ottobre 2008
Message:
Restructuring the file system interfaces and nativefs implementation
Moving filters to listeners
----
...
Deleted :
/mina/ftpserver/trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/FileObject.java
...
Added :
/mina/ftpserver/trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/FtpFile.java
(Copy from path:
/mina/ftpserver/trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/FileObject.java,
Revision, 693183)
...
My patch is only about renaming the relevant method in the
FileSystemView interface according to new name introduced in 701234.
Andrea Francia (JIRA) wrote:
After the renaming FileObject->FtpFile the method
FileSystemView#getFileObject should renamed
---------------------------------------------------------------------------------------------
Key: FTPSERVER-189
URL:
https://issues.apache.org/jira/browse/FTPSERVER-189
Project: FtpServer
Issue Type: Bug
Reporter: Andrea Francia
I propose to rename from:
FtpFile getFileObject(String file) throws FtpException;
to:
FtpFile getFile(String path) throws FtpException;
There is a patch for this.
--
Andrea Francia
http://andreafrancia.blogspot.com/2008/07/colinux-linux-dentro-windows.html
