If they are not being used, delete them.  I can say that I have never used them.

--Mark

On Sat, Nov 8, 2008 at 5:43 PM, Emmanuel Lecharny <[EMAIL PROTECTED]> wrote:
> Hi,
>
> those methods are called when a new filter is registred into the chain.
> However, the few filters implementing those methods typically check that the
> added filter is not already present in the chain :
>
> ProtocolCodecFilter, ExecutorFilter, KeepAliveFilter :
>   public void onPreAdd(IoFilterChain parent, String name,
>           NextFilter nextFilter) throws Exception {
>       if (parent.contains(this)) {
>           throw new IllegalArgumentException(
>                   "You can't add the same filter instance more than once.
>  Create another instance and add it.");
>
> but SslFilter does some intrigating things, which seems to me deserves to be
> found in a init() method.
>
> IMO, pre/post operation are just a bit too much. The way it should be done
> is :
> - init the filter
> - add/remove a filter from the chain
>
> and that's it.
>
> Anyone has a better vision of what those method are good for ?
>
>
> --
> --
> cordialement, regards,
> Emmanuel Lécharny
> www.iktek.com
> directory.apache.org
>
>
>

Reply via email to