> Emmanuel Lecharny [mailto:[EMAIL PROTECTED] wrote: > > Hi guys,
Hi! > I was hit by the very same proble Steve already met one year ago (as > I'm > just migrating from 1.1.7 now). Here is a thread which describe the > exact problem I have and Steve had : > > http://www.mail-archive.com/[email protected]/msg06199.html Oh, just forgot about that. > The "solution" proposed one year ago ("...what you want to do > (overriding AbstractIoSession.write()) can be done alternatively by > adding afilter that intercepts the write call...") seems totally > overkilling, compared to the risk someone will ever override the > Session > object but to write a mock object and be hit because he overriden > incorrectly the write() method. > > This is typically a bad decision. > > I will remove those 'final' keywords which weren't present in the code > for years, and never been a problem. That would be nice. > If someone has a very good reason to keep those 'final' there, I will > suggest : > - first to have a valid reason for having them in an abstract class > - second to propose a valid solution which does not implies the > addition > of a filter or anything as crazy. first: I did understand the reason, but I doubt it's worth the pain. second: A proxy to the DummySession could solve the problem, is easy to make and is a fantastic example of an unnecessary workaround... regards Steve
