2008/12/4 Sai Pullabhotla (JIRA) <[EMAIL PROTECTED]> > > [ > https://issues.apache.org/jira/browse/FTPSERVER-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653293#action_12653293] > > Sai Pullabhotla commented on FTPSERVER-229: > ------------------------------------------- > > Nicklas, > > That's a very valid point. I did not even think about it. I guess, it > could stay the way it is or if we want, we can create a > SynchronizedSimpleDateFormat class using the Deligator pattern, but > synchronize some methods like format and parse. Surely, the > synchronization would have a performance hit too. We need to think > some more about this. >
Yeah I was nearly caught here too. Anyway since I had already ported the DateFormat to DateUtils.java when I noticed the synchronization issue, I think we can leave it there so it will be easier to port if we decided to synchronize the method. I don't know if that sohuld be necessary though. Synchronized/new object: what do you like better? > > Thanks. > > Sai Pullabhotla > Phone: (402) 408-5753 > Fax: (402) 408-6861 > www.jMethods.com > > > > > On Thu, Dec 4, 2008 at 5:37 AM, Niklas Gustavsson (JIRA) > > > > MFMT Command - Code Enhancement > > ------------------------------- > > > > Key: FTPSERVER-229 > > URL: https://issues.apache.org/jira/browse/FTPSERVER-229 > > Project: FtpServer > > Issue Type: Improvement > > Components: Core > > Affects Versions: 1.0.0-M4 > > Reporter: Sai Pullabhotla > > Assignee: David Latorre > > Fix For: 1.0.0-RC1 > > > > > > MFMT Command - in the source code for this command (MFMT.java), the > DateFormat and > > its configuration should be moved to static block for performance and to > reduce object creations. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
