Hi Niklas and Emmanuel, Thanks for your confirmations. I just submit a bug [ https://issues.apache.org/jira/browse/FTPSERVER-245] and I attach a data race report generated by our tool. I hope that it is helpful for the data races bugs correction. We are glad to help if you have questions about the report and our tool. Thanks!
Regards, Daniel 2008/12/18 Emmanuel Lecharny <[email protected]> > Niklas Gustavsson wrote: > > I think we need to synchronize a bunch of the methods in > > AbstractIoSession, for example increaseReadMessages(). It updates a > > bunch of fields which would be inconsistent in the current design. > > > Yep. And we also have to rethink all this area which is absolutely a > mess. So far, those counters where added while Trustin was working on a > throttling system, which has been removed since then. But the counters > are still around, and they are not used anymore. > > I guess we should at least make those methods thread safe, and also > avoid calling them if they are not usefull. Some kind of configuration > can enable or disable them. > > I have to check the code... > > In any case, we are very interested in having any kind of report about > race conditions ! > > Thanks ! > > > -- > -- > cordialement, regards, > Emmanuel Lécharny > www.iktek.com > directory.apache.org > > >
