[ 
https://issues.apache.org/jira/browse/DIRMINA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666931#action_12666931
 ] 

Sanjeev Sachdev commented on DIRMINA-657:
-----------------------------------------

Adding these API will make design cleaner:

IOHandler has methods to receive other events ("Session Created", "Session 
Closed", etc.). Similary, it should have methods to deal with events like, 
"Session Secured" / "Session Unsecured". Currently, "Session Secured" / 
"Session Unsecured" events are treated as a "Message Received" events. So if 
you want to handle "Session Secured" / "Session Unsecured" events, you have to 
check every message that is passed to IOHandler.messageReceived() method if it 
is "Session Secured" / "Session Unsecured" message. IOHandler.messageReceived() 
should be only for application layer protocol "Message Received" events only. 

> SSL Filter and IoHandler.
> -------------------------
>
>                 Key: DIRMINA-657
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-657
>             Project: MINA
>          Issue Type: Improvement
>          Components: Filter, Handler
>    Affects Versions: 1.1.7
>            Reporter: Sanjeev Sachdev
>            Priority: Minor
>
> When the session is secured or unsecured, SSLFilter notifies the IOHandler 
> about the same, by emitting a special message object with a 
> IoHandler.messageReceived(IoSession, Object)  event. 
> Instead, IOHandler should have events like IoHandler.sessionSecured() and 
> IoHandler.sessionUnsecured().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to