[
https://issues.apache.org/jira/browse/DIRMINA-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Costello updated DIRMINA-658:
----------------------------------
Description:
BufferedWriteFilter does not pass along the session closed or exception caught
events up the filter chain. This will cause problems with any application that
needs to clean up resources on client disconnect or try to reconnect to a
server if it has been disconnected. From looking at the other filters, it
doesn't look like this omission was intentional
Patch:
Index: src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
===================================================================
--- src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
(revision 738176)
+++ src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
(working copy)
@@ -243,6 +243,7 @@
public void exceptionCaught(NextFilter nextFilter, IoSession session,
Throwable cause) throws Exception {
free(session);
+ nextFilter.exceptionCaught(session, cause);
}
/**
@@ -252,5 +253,6 @@
public void sessionClosed(NextFilter nextFilter, IoSession session)
throws Exception {
free(session);
+ nextFilter.sessionClosed(session);
}
}
\ No newline at end of file
was:BufferedWriteFilter does not pass along the session closed or exception
caught events up the filter chain. This will cause problems with any
application that needs to clean up resources on client disconnect or try to
reconnect to a server if it has been disconnected. From looking at the other
filters, it doesn't look like this omission was intentional
> BufferedWriteFilter does not pass session closed or exception caught events
> up the filter chain
> ------------------------------------------------------------------------------------------------
>
> Key: DIRMINA-658
> URL: https://issues.apache.org/jira/browse/DIRMINA-658
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 2.0.0-M4
> Reporter: John Costello
> Attachments: Test.java
>
>
> BufferedWriteFilter does not pass along the session closed or exception
> caught events up the filter chain. This will cause problems with any
> application that needs to clean up resources on client disconnect or try to
> reconnect to a server if it has been disconnected. From looking at the other
> filters, it doesn't look like this omission was intentional
> Patch:
> Index: src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
> ===================================================================
> --- src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
> (revision 738176)
> +++ src/main/java/org/apache/mina/filter/buffer/BufferedWriteFilter.java
> (working copy)
> @@ -243,6 +243,7 @@
> public void exceptionCaught(NextFilter nextFilter, IoSession session,
> Throwable cause) throws Exception {
> free(session);
> + nextFilter.exceptionCaught(session, cause);
> }
>
> /**
> @@ -252,5 +253,6 @@
> public void sessionClosed(NextFilter nextFilter, IoSession session)
> throws Exception {
> free(session);
> + nextFilter.sessionClosed(session);
> }
> }
> \ No newline at end of file
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
