Julien Vermillard wrote:
Le Tue, 10 Mar 2009 16:32:37 +0100,
Emmanuel Lecharny <[email protected]> a écrit :
On Tue, Mar 10, 2009 at 4:18 PM, Victor <[email protected]>
wrote:
Hello,
I have finally found where the problem was. It was in my code:
I called ConnectionRequest.cancel() for a connection request in the
"done" state. Now I added the check:
if (!connectionRequest.isDone()) {
connectionRequest.cancel();
}
I think it would be great to add this check to ConnectionRequest
class itself. Otherwise mina adds the request to cancelQueue, but
in fact there is nothing to cancel - that's why the Connector's
run() loop works incorrectly. What do you think?
Well, i'm a bit relieved that you found the problem you had, as I
didn't had any clue about what could hev been the origin of your
problem.
However, your suggestion is smart. We may want to add a check in the
cancel() method to avoid such a problem.
Can you fill a JIRA describing the problem and including the solution
proposal ?
Many thanks !
Yep why not firing a good old exception if the task is already
completed ?
I fixed it in a simpler way : if the connection is already closed, then
we do nothing.
Patched in http://svn.apache.org/viewvc?rev=752297&view=rev
Please tell me if it's OK.
Thanks !
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
