In fact, thinking a little bit more about this, I lean towards looking
into the history of this line to see what was intented to be tested
here, exactly.
As I went through all the Vysper files today (very quickly, I admit) to
remove the @version tag (and this is why I like to do that by hand,
instead of using sed), I also found some things to fix :
- there are some tabs here and there in the code ( a lot !)
- Javadoc has to be added (but this can be done before the first release)
- I haven't checked yet, but as we have a format convention in MINA, we
have to see if Vysper is consistent with those rules (or we may discuss
them, to see if they are OK for Vysper)
Regarding those special non-ascii chars, we may need a global check on
the code (checking for any byte above 0x7F in the files)
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
