[
https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717716#action_12717716
]
Bernd Fondermann commented on VYSPER-72:
----------------------------------------
RE xep0049.patch: I can't apply the patch yet, but we will get there. This is a
great improvement for Vysper. Please keep contributing!
At first: Please adopt to the project's code formatting. Please use 4 space
indentions (and no tabs).
Avoid @Override when implementing interfaces, as we are still supporting Java
5, where this is a compile error.
StanzaErrorCondition: bad-format is not a stanza error condition, it's a stream
error. Please refer to RFC3920 for more details.
If you need a stanza error, chose a different condition.
If you need bad-format, create a stream error, but this would terminate the
session, so I guess it is not an option.
What does the XEP say?
Otherwise, the patch looks pretty good (pending me reading the full private
data XEP)!
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep0049.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData
> IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
