[
https://issues.apache.org/jira/browse/DIRMINA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718669#action_12718669
]
Edouard De Oliveira commented on DIRMINA-716:
---------------------------------------------
Yes i tested. In our case the negative impact isn't as bad but after digging
down the code i think i can conclude that the finalize method is useless as the
method clear() will always be called when session is closed so i patched the
file and removed it
> Get rid of "finalize" method in AbstractIoFilterChain.java
> ----------------------------------------------------------
>
> Key: DIRMINA-716
> URL: https://issues.apache.org/jira/browse/DIRMINA-716
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.0-M5
> Reporter: Yongxing Wang
> Assignee: Edouard De Oliveira
> Fix For: 2.0.0-M7
>
>
> The finalize method in AbstractIoFilterChain.java can possibly cause OOM
> error when the system is under very heavy load. The negative impact of
> "finalize" method can be found at:
> http://www.fasterj.com/articles/finalizer1.shtml
> AbstractIoFilterChain holds a reference to Session object which can hold a
> list of unwritten data. The deterministic run of Finalizer can very well
> cause memory not fred up on time under heavy load. And it can certainly cause
> very bad memory usage pattern and contribute to the overall heavy system load.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
