Le Thu, 26 Nov 2009 16:01:32 +0100, Norman Maurer <[email protected]> a écrit :
> Well I'm not a MINA committer but I would keep the "Filter" naming. > Like Emanuell said, its a well known "pattern". > > Bye, > Norman Hey :) If some opinion matter on methods and class name, it's the users one more than the committers one. Thanks for the feedback. Julien > > 2009/11/26 Julien Vermillard <[email protected]>: > > Le Thu, 26 Nov 2009 15:55:57 +0530, > > Ashish <[email protected]> a écrit : > > > >> Have started looking into the FilterChain implementation and here > >> are some initial thoughts > >> > >> 1. Rename IoFilterChain as IoChannel - it gives a more clear > >> picture and is easy to understand like imagine as a Channel with > >> multiple stages aka IoFilters. > >> This came while I was drawing on paper to design something. > > > > > > I propose IoPipe/IoPipeline, because for me a bunch of filter > > stacked on each other is a Pipe in the Unix meaning. > > > > > >> > >> 2. Have captured a couple of API's that are core to IoChannel > >> > >> IoSession getSession(); > >> > >> IoFilter getHead(); > >> > >> IoFilter getNextFilter(IoFilter currentFilter); > >> > >> List<IoFilter> getAll(); > >> > >> void addFilter(String name, IoFilter filter); > >> > >> void addAfter(String baseName, String filterName, > >> IoFilter filter); > >> > >> void removeFilter(String filterName); > >> > >> There are a lot more API's in current implementation. I am not > >> sure if we need replace API or not. > >> Also do we need the Generics version of these API's or its fine > >> without them? > >> > >> This is just the initial list. Will checkin the files once the name > >> change is OK with everyone. > >> > >
signature.asc
Description: PGP signature
