Good work. Would it be possible to increase the frequency of patches (and thus have smaller, more isolated patches which are easier to review)?
On Tue, Jun 29, 2010 at 1:00 PM, Bogdan Ciprian Pistol <[email protected]> wrote: > * Session restart after SASL auth is implemented. It does not > forward the restart request from the BOSH client to Vysper, but > instead responds with the approriate features from > ServerResponses#getFeaturesForAuthentication(). The method is private > and I changed it (in the patch) to be public. If you think this is not > appropriate I will strip instead the response from > ServerResponses#getStreamOpener(). I think it makes sense to have this as a public method. On a different note: we need to get unit tests in place. Could you fit this into the next week? I'm worried we're designing the code without thinking about testability. /niklas
