[ 
https://issues.apache.org/jira/browse/DIRMINA-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907984#action_12907984
 ] 

Emmanuel Lecharny commented on DIRMINA-794:
-------------------------------------------

Patch applied, tests passing with flying color. I will commit it.

Thanks !

> Log4jXmlFormatter is unnecessarily tied to BasicMDCAdapter
> ----------------------------------------------------------
>
>                 Key: DIRMINA-794
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-794
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Justin Edelson
>            Assignee: Emmanuel Lecharny
>         Attachments: DIRMINA-794.patch
>
>
> The class org.apache.mina.util.Log4jXmlFormatter will only output the 
> contents of the SLF4J MDC if the MDCAdapter used is an instance of 
> BasicMDCAdapter. This has two problems:
> 1) It excludes Log4j and Logback, the MDCAdapters for which do not extend 
> BasicMDCAdapter
> 2) It creates a dependency on (what should be) an internal SLF4J class

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to