[
https://issues.apache.org/jira/browse/DIRMINA-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965046#action_12965046
]
Emmanuel Lecharny commented on DIRMINA-782:
-------------------------------------------
I applied the patch on trunk, but when running the tests, I got some failures :/
-------------------------------------------------------------------------------
Test set: org.apache.mina.filter.stream.FileRegionWriteFilterTest
-------------------------------------------------------------------------------
Tests run: 8, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 0.551 sec <<<
FAILURE!
testWriteSingleBufferFile(org.apache.mina.filter.stream.FileRegionWriteFilterTest)
Time elapsed: 0.004 sec <<< FAILURE!
java.lang.AssertionError:
Unexpected method call filterWrite((0x0000001E: mina dummy, server, ? => ?),
WriteRequest: HeapBuffer[pos=0 lim=4 cap=4: 01 02 03 04]):
filterWrite((0x0000001E: mina dummy, server, ? => ?), Expected a
WriteRequest with the message 'HeapBuffer[pos=0 lim=4 cap=4: 01 02 03 04]'):
expected: 1, actual: 2
messageSent((0x0000001E: mina dummy, server, ? => ?), WriteRequest:
org.apache.mina.core.file.defaultfilereg...@48baa31b): expected: 1, actual: 0
at
org.easymock.internal.MockInvocationHandler.invoke(MockInvocationHandler.java:43)
at
org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:72)
at $Proxy7.filterWrite(Unknown Source)
at
org.apache.mina.filter.stream.AbstractStreamWriteFilter.filterWrite(AbstractStreamWriteFilter.java:103)
at
org.apache.mina.filter.stream.AbstractStreamWriteFilterTest.testWriteSingleBufferFile(AbstractStreamWriteFilterTest.java:162)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> Combination of SslFilter & FileRegionWriteFilter causes messageSent events to
> be lost
> -------------------------------------------------------------------------------------
>
> Key: DIRMINA-782
> URL: https://issues.apache.org/jira/browse/DIRMINA-782
> Project: MINA
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.0.0-RC1
> Reporter: Adam Brown
> Assignee: Emmanuel Lecharny
> Fix For: 2.0.2
>
> Attachments: FileRegionWriteFilterTest.java, ssl-file-region.patch
>
>
> When SslFilter & FileRegionWriteFilter are the last 2 filters on the outgoing
> end of a filter chain, you lose the messageSent notification for an IoBuffer
> if a write of the IoBuffer is immediately followed by a write of a FileRegion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
