[ 
https://issues.apache.org/jira/browse/SSHD-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030893#comment-13030893
 ] 

Taras Puchko commented on SSHD-131:
-----------------------------------

SshFile is a single abstraction for SftpSubsystem and ScpCommand. SftpSubsystem 
calls handleClose() but ScpCommand does not.

So I cannot rely on handleClose() at all since I cannot distinguish those two 
cases. If I do some cleanup in handleClose() there will be resource leaks when 
an SshFile is created by the ScpCommand.


> ScpCommand should call SshFile.handleClose() when done with a file.
> -------------------------------------------------------------------
>
>                 Key: SSHD-131
>                 URL: https://issues.apache.org/jira/browse/SSHD-131
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 0.5.0
>            Reporter: Taras Puchko
>
> SshFile.handleClose() is useless, since ScpCommand never calls it and an 
> SshFile cannot detect if it's being used by SftpSubsystem or ScpCommand.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to