[ 
https://issues.apache.org/jira/browse/FTPSERVER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niklas Gustavsson closed FTPSERVER-418.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.0
                   1.0.6
         Assignee: Niklas Gustavsson

Very nice catch! Fixed in rev 1138603 and 1138613

> Ignored/invalid assertion failure in FtpLetReturnDefaultTest.testLogin() 
> -------------------------------------------------------------------------
>
>                 Key: FTPSERVER-418
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-418
>             Project: FtpServer
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Niklas Gustavsson
>             Fix For: 1.0.6, 1.1.0
>
>
> The FtpLetReturnDefaultTest.testLogin() test defines a callback which 
> overrides the onLogin method.
> The onLogin method includes the following assertion:
> assertNotNull(session.getUserArgument());
> However, this will have no effect (other than generating a log message if the 
> level allows it) because the method is called by a different thread from the 
> test case.
> Note that the null check is currently being triggered, but the test is not 
> failing.
> Either the null check is incorrect, or there is a bug that is not being 
> detected.
> Either way, something needs to be fixed...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to