[
https://issues.apache.org/jira/browse/DIRMINA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136938#comment-13136938
]
Emmanuel Lecharny commented on DIRMINA-828:
-------------------------------------------
There is a big design issue in the decoder implementation : it's a stateful
decoder.
The resulting decoded data structure must be external, and moved to the
session, otherwise you may have big problems in a multi-threaded environment.
This is only a matter of creating the Header as an inner class in the decoder,
and to instanciate it in the sessionCreated() event handler, then to store it
as a session attribute.
Otherwise, I have reviewed the code, and made it a separate module. Once the
above issue is fixed, I can commit it.
> RFC1006 protocol codec
> ----------------------
>
> Key: DIRMINA-828
> URL: https://issues.apache.org/jira/browse/DIRMINA-828
> Project: MINA
> Issue Type: New Feature
> Components: Core
> Reporter: Francis ANDRE
> Labels: features
> Attachments: RFC1006CodecFactory.java, RFC1006Decoder.java,
> RFC1006DecoderTest.java, RFC1006Encoder.java, RFC1006EncoderTest.java,
> RFC1006Protocol.java,
> org.apache.mina.filter.codec.rfc1006.RFC1006EncoderTest.txt
>
>
> Hi
> Here the files of the RFC1006 protocol codec for inclusion in the next
> release of Mina.
> org.apache.mina.filter.codec.rfc1006.RFC1006Encoder
> org.apache.mina.filter.codec.rfc1006.RFC1006Decoder
> org.apache.mina.filter.codec.rfc1006.RFC1006CodecFactory
> org.apache.mina.filter.codec.rfc1006.RFC1006Protocol
> plus the JUnit files
> org.apache.mina.filter.codec.rfc1006.RFC1006DecoderTest
> org.apache.mina.filter.codec.rfc1006.RFC1006EncoderTest
> Rgds
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
