On 28 November 2011 09:38, Julien Vermillard <[email protected]> wrote: > On Mon, Nov 28, 2011 at 10:05 AM, Emmanuel Lécharny > <[email protected]> wrote: >> On 11/28/11 9:43 AM, Julien Vermillard wrote: >>> >>> On Sun, Nov 27, 2011 at 11:33 PM, Emmanuel Lécharny >>> <[email protected]> wrote: >>>> >>>> On 11/27/11 10:18 PM, Christian Schwarz wrote: >>>>> >>>>> ...one more thing, >>>>> >>>>> the sun.reflect.generics.reflectiveObjects.NotImplementedException's >>>>> should >>>>> be replaced by java.lang.UnsupportedOperationException's. My IDE refuse >>>>> the >>>>> compilation because the NotImplementedException is not public API >>>>> (access >>>>> restriction). >>>> >>>> Right ! >>>> >>>> Btw, I will implement the missing code soon, so it's just a placeholder >>>> atm. >>>> >>> We bneed commons coding rules because I used "new >>> RuntimeException("not implemented")" >> >> We certainly need to define a common set of exceptions we should use at >> Mina. MinaException. We should also discuss if we want them to be runtime or >> checked exceptions. >> > > On the check/runtime : > checked are usual error which should be handled by the API user : a > decoding error because the client is sending craps
+1 Generally used for recoverable conditions. > runtime are for bug or problem the API can't do much, he just want to > log the error : NPE, socket exceptions, not implemented exception Not sure about socket exception - that may be transient, e.g. temporary lack of resources Also, please use standard Exceptions for standard errors rather than creating subclasses of existing ones. Sometimes it is necessary to create new Exceptions/Errors, but that should be the exception (!). > Julien >
