On 8 June 2012 16:48, sebb <[email protected]> wrote: > On 8 June 2012 10:37, Guillaume Nodet <[email protected]> wrote: >> On Fri, Jun 8, 2012 at 11:25 AM, sebb <[email protected]> wrote: >>> On 7 June 2012 16:10, Guillaume Nodet <[email protected]> wrote: >>>> I've uploaded a release at >>>> https://repository.apache.org/content/repositories/orgapachemina-201/ >>>> >>>> The release notes are available at >>>> >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12317953 >>>> >>>> The vote will be opened for at least 72 hours. Please review and vote. >>> >>> Where is the SVN tag? >> >> http://svn.apache.org/repos/asf/mina/sshd/tags/sshd-0.7.0/ > > Ideally that should have an RC suffix in case the RC fails and has to be > redone.
Two files don't have AL headers: sshd-core/src/main/java/org/apache/sshd/agent/SshAgentConstants.java sshd-core/src/test/java/org/apache/sshd/util/BogusChannel.java > Otherwise the tag is not immutable. > >>> >>> KEYS file? >> >> http://svn.apache.org/repos/asf/mina/KEYS >> >>> >>> -1 >>> >>> The NOTICE file in the source archive references code that is not >>> actually included. >> >> Those are notices on the main dependencies, especially those inside >> the binary distribution. This is slightly over protective, but erring >> on the good side is better. > > It's not good to claim that a release contains code when it does not. > > The NOTICE file is for *required* notices only. > The dependency entries are obviously not required if they are not present. > > The contents of NOTICE files are generally transitive, so it's vital > that they are accurate. > >>> >>>> -- >>>> ------------------------ >>>> Guillaume Nodet >>>> ------------------------ >>>> Blog: http://gnodet.blogspot.com/ >>>> ------------------------ >>>> FuseSource, Integration everywhere >>>> http://fusesource.com >> >> >> >> -- >> ------------------------ >> Guillaume Nodet >> ------------------------ >> Blog: http://gnodet.blogspot.com/ >> ------------------------ >> FuseSource, Integration everywhere >> http://fusesource.com
