On 21 August 2012 14:14, Emmanuel Lécharny <[email protected]> wrote: > Le 8/21/12 12:23 PM, sebb a écrit : >> >> On 21 August 2012 10:12, Emmanuel Lécharny <[email protected]> wrote: >>> >>> >>> A temporary tag has been created (it can be removed if the vote is not >>> approved):http://svn.apache.org/viewvc/mina/tags/2.0.5/ >> >> It would be better to use an immutable tag with an RCn suffix which is >> renamed/copied when the vote succeeeds. > > Yes, but this is not the way we chose to proceed at MINA... Maybe for MINA 3 > ? > >> >> Some issues with SVN props (non-blocking): >> >> svn ps svn:eol-style native >> >> mina-statemachine/src/main/java/org/apache/mina/statemachine/annotation/OnEntry.java >> svn ps svn:eol-style native >> >> mina-statemachine/src/main/java/org/apache/mina/statemachine/annotation/OnExit.java >> svn ps svn:eol-style native >> >> mina-statemachine/src/main/java/org/apache/mina/statemachine/transition/AbstractSelfTransition.java >> svn ps svn:eol-style native >> >> mina-statemachine/src/main/java/org/apache/mina/statemachine/transition/SelfTransition.java >> svn ps svn:eol-style native >> >> mina-statemachine/src/main/java/org/apache/mina/statemachine/transition/MethodSelfTransition.java > > > Fixed with http://svn.apache.org/viewvc?rev=1375490&view=rev > >> >> -1: Missing AL header: >> >> ======================================================================= >> ==D:/RC/2.0.5/ImprovedJavaConventions.xml >> ======================================================================= >> <?xml version="1.0" encoding="UTF-8" standalone="no"?> >> <profiles version="10"> >> <profile name="Improved Java Conventions" version="10"> >> <setting id="org.eclipse.jdt.core.formatter.align_type_members_on_columns" >> value="false"/> >> >> Seems wrong for this file to be at top-level; also it ought to be >> identified as being for Eclipse only. >> I recommmend using an approach like the one Tomcat use: >> >> http://svn.apache.org/repos/asf/tomcat/trunk/res/ide-support/eclipse/ >> >> Note that they include AL headers. > > > I have created a sub-directory "resources" and moved this file there. We > can't inject the ASF header in it, as it's a generated file (so per se, it's > an eclipse file).
But you (or someone) generated the file by setting up the required settings. > >> >>> The newly approved Nexus has been used for the preparation of this >>> release >>> and >>> all final artifacts are stored in a staging repository: >>> https://repository.apache.org/content/repositories/orgapachemina-023/ >>> >>> The subversion revision for the tag is : 1375426 >>> http://svn.apache.org/viewvc?rev=1375426&view=rev >>> >>> The sources distributions are available for download on : >>> >>> https://repository.apache.org/content/repositories/orgapachemina-023/org/apache/mina/mina-parent/2.0.5/ >> >> -1: There does not seem to be a binary distribution package anywhere. > > > I forgot to pushed the binary on my people.apache.org account. Will do... If Maven is set up correctly, this should happen automatically; both the source and binary packages should be included. You may need to use "package" before "deploy", i.e. mvn package deploy .... >> >> -1: The top-level NOTICE.txt file has: >> Apache MINA >> Copyright 2007 The Apache Software Foundation. >> >> That should probably be: >> >> Apache MINA >> Copyright 2007-2012 The Apache Software Foundation. >> >> Also are you sure that all the content is *required* ? >> >> The ASF releases source (and SVN is source) so the NOTICE file should >> relate to what is actually included. > > > Right. We just depend on this libs, we don't include any part of the sources > from those projects. No need to have them listed in the NOTICES.txt file > then. > > Fixed with http://svn.apache.org/viewvc?rev=1375521&view=rev > > >> If MINA releases a binary bundle which includes 3rd party items, the >> N&L files it contains should be updated accordingly. >> > Working on it. > > Thanks ! > > > -- > Regards, > Cordialement, > Emmanuel Lécharny > www.iktek.com >
