[ 
https://issues.apache.org/jira/browse/VYSPER-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456632#comment-13456632
 ] 

Joonas Koivunen commented on VYSPER-4:
--------------------------------------

I have now in my branch the following:
 1. parsing processing instructions into piTarget and piData
 2. parsing of xml declaration as a special case
 3. when a feature is set, attempt to use charset by the name of encoding 
-atrribute of xml declaration
 4. tests for the above

My branch is at https://github.com/koivunej/vysper/tree/vysper-4 up for review. 
If you don't like my changes to test code it should be easy to pick only the 
following commits:
 * 8a3f0c5ef5a7a6392a93b06bf22b57341a2996fb # actual code
 * cc41dd61fb61d7e333a32309905ff9a8036debf6 # tests for 
GenericKeyValueParserImpl
 * 7d15c44eb8a6c78f7ffc084de5108edbdb37f8f1 # feature requirement
 * 03ff60fb9bae4b6a119541a85df029a61b3a8de7 # removal of excessive debug code
 * 45754fa3d5a7a738d443cf7c17c6eebd0031762a # documentation for 
GenericKeyValueParserImpl and lowercasing support
 * 239baebc350674127cbc3148a912ecb5e822ae5a # the use of lowercasing in 
XMLParser

The above are the top six in https://github.com/koivunej/vysper/commits/vysper-4

If you have github logins you can review the code in-github.

All tests pass like they did with current trunk at 1365553.
                
> Handle non UTF-8 encoded streams
> --------------------------------
>
>                 Key: VYSPER-4
>                 URL: https://issues.apache.org/jira/browse/VYSPER-4
>             Project: VYSPER
>          Issue Type: Bug
>          Components: connection handshake, transport
>            Reporter: Bernd Fondermann
>
> currently, UTF-8 encoding is hardcoded in stream parser, regardless what the 
> initiating party is providing

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to