[
https://issues.apache.org/jira/browse/DIRMINA-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462866#comment-13462866
]
Emmanuel Lecharny commented on DIRMINA-645:
-------------------------------------------
You can fetch the SslFilter from the chain, and call the startSsl() method :
LOG.info( "Handling StartTLS request." );
IoFilterChain chain = session.getIoSession().getFilterChain();
SslFilter sslFilter = ( SslFilter ) chain.get( "sslFilter" );
if ( sslFilter == null )
{
sslFilter = new SslFilter( sslContext );
chain.addFirst( "sslFilter", sslFilter );
}
else
{
sslFilter.startSsl( session.getIoSession() );
}
This is what we do in ApacheDS.
Note that I'm not sure that it works if the SslFilter is not in the chain when
the server is started...
> SslFilter should start initiating handshake from sesionCreated() rather than
> from onPostAdd()
> ---------------------------------------------------------------------------------------------
>
> Key: DIRMINA-645
> URL: https://issues.apache.org/jira/browse/DIRMINA-645
> Project: MINA
> Issue Type: Improvement
> Components: Filter
> Affects Versions: 2.0.0-M3
> Reporter: Dan Mihai Dumitriu
> Fix For: 2.0.5
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Here's the situation I needed to get working. We want to make a secure
> connection through a SOCKS 5 proxy. So, one would think that just using the
> SslFilter and and the ProxyConnector (which adds the ProxyFilter at the
> bottom of the stack) would just do it. Unfortunately, it does not work quite
> right out of the box. The ProxyFilter only fully initializes itself after
> the sessionCreated() method is called. Meanwhile, the SslFilter tries to
> start the handshake (i.e. calls initiateHandshake()) from the onPostAdd()
> method, which occurs before the sessionCreated() is called.
> Moving the initiateHandshake() from onPostAdd() to sessionCreated() in
> SslFilter, as shown below, seems to fix the problem.
> @Override
> public void onPostAdd(IoFilterChain parent, String name,
> NextFilter nextFilter) throws SSLException {
> // if (autoStart) {
> // initiateHandshake(nextFilter, parent.getSession());
> // }
> }
>
> @Override
> public void sessionCreated(NextFilter nextFilter, IoSession session)
> throws Exception {
> super.sessionCreated(nextFilter, session);
>
> if (autoStart) {
> initiateHandshake(nextFilter, session);
> }
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
