[ 
https://issues.apache.org/jira/browse/SSHD-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548636#comment-13548636
 ] 

Guillaume Nodet commented on SSHD-204:
--------------------------------------

I'll commit your patch as soon as the git migration is completed (the svn repo 
has been made read-only).
                
> [PATCH] Provide callback-driven I/O mechanism for Command
> ---------------------------------------------------------
>
>                 Key: SSHD-204
>                 URL: https://issues.apache.org/jira/browse/SSHD-204
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 0.8.0
>            Reporter: Kohsuke Kawaguchi
>            Assignee: Guillaume Nodet
>         Attachments: SSHD-204.patch
>
>
> In the current abstraction, the Command interface receives InputStream to 
> read the data from the client, which means I pretty much have to allocate a 
> thread to drain this. Look at MINA's own InvertedShellWrapper, which does 
> exactly this.
> This is often rather inefficient, especially given that MINA SSHD delivers 
> the data from the client to ChannelSession as callbacks. To fix this, it 
> should allow Command to receive these callbacks. This would allow me to 
> further chain other asynchronous IO (such as socket connection to other 
> servers behind) and implement my Command in a truly asynchronous fashion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to