I think that Netty 4 is not yet releases (4.0.0.CR3 and not 4.0.0.Final). So I think we should keep Netty3 tests.
Jeff On Mon, May 20, 2013 at 8:34 AM, Julien Vermillard <[email protected]>wrote: > Would be great if you upgrade the netty test to v4 ! > By the way, should we keep the netty 3 tests ? is it "faster" in some case > ? > > Julien > > On Sun, May 19, 2013 at 9:15 PM, Norman Maurer > <[email protected]> wrote: > > Alright... Let me see if I find the time over the next days. > > > > Am 19.05.2013 um 18:48 schrieb Emmanuel Lécharny <[email protected]>: > > > >> Le 5/19/13 6:27 PM, Norman Maurer a écrit : > >>> If you explain me how to do I can even take care ;) > >> > >> This is pretty simple :) > >> > >> The code is in > http://svn.apache.org/repos/asf/mina/mina/trunk/benchmarks/ > >> > >> we have benchmarks for Netty3 and MINA3, the idea is to add a > >> combinaison for Netty4. > >> > >> The type of clients and servers are defined in the BenchmarkFactory > >> class. You have to add a Netty4_udp and Netty4_tcp. Then the > >> BenchmarkClientFactory and BenchmarkServerFactory class have to be > >> augmented to handle the Netty4 clients and server for TCP and UDP. Those > >> are pretty straghtforward modifications. > >> > >> Then you have to write the real flesh : in the nio/tcp and nio/udp > >> packages, you have to add the classes to create the Netty4 client and > >> server for UDP and TCP. This is where the initialization is done. > >> > >> Last, not least, the tests themselves are in some new classes names > >> > [Netty4|Netty3|Mina3]ClientVs[Netty4|Netty3|Mina3]Server[Tcp|Udp]BenchmarkBinaryTest. > >> Those new classes just have to reference the correct type defined in the > >> BenchmarkFactory. > >> > >> Thanks a lot of the help ! > >> > >> -- > >> Regards, > >> Cordialement, > >> Emmanuel Lécharny > >> www.iktek.com > >> > -- Jeff MAURY "Legacy code" often differs from its suggested alternative by actually working and scaling. - Bjarne Stroustrup http://www.jeffmaury.com http://riadiscuss.jeffmaury.com http://www.twitter.com/jeffmaury
