[
https://issues.apache.org/jira/browse/DIRMINA-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758802#comment-13758802
]
Mark Phillips commented on DIRMINA-907:
---------------------------------------
In my first attempt to integrate the submitted code into a working environment
I encountered and fixed a bug which prevented the WS handshake response being
written. Line 78 of WebSocketDecoder.java is:
session.write(wsResponse);
But should be:
session.write(wsResponse.getResponse());
This seems to correctly send the response and establish the connection.
(Alternately WebSocketHandShakeResponse could implement toString() to return
the response; but the fix I've suggested seems more intuitive to read.)
Dhruv, many thanks to you and your company for this submission! I think this
feature will be appreciated by many MINA users.
> Create a WebSocket iofilter for use in Apache Mina TCP servers
> --------------------------------------------------------------
>
> Key: DIRMINA-907
> URL: https://issues.apache.org/jira/browse/DIRMINA-907
> Project: MINA
> Issue Type: New Feature
> Components: Filter, Protocol - HTTP, Transport
> Reporter: dhruv chopra
> Attachments: MinaCodecUsage.png, WebSocketFilter.zip
>
>
> Shephertz has created a websocket iofilter that can be added in Apache mina
> tcp server chain. The features of this codec are
> 1) Works with binary data sent/received over websocket
> 2) Abstracts the client details from the Handler code i.e. the handler need
> not be aware that the remote endpoint is a browser or native client.
> 3) Tested with binary data sent/received on latest chrome and firefox
> browsers. IE 9 doesn't support websockets and we will make changes if
> required for IE 10 when its released and if it supports websockets.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
