[
https://issues.apache.org/jira/browse/DIRMINA-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Lecharny resolved DIRMINA-950.
---------------------------------------
Resolution: Fixed
The mark() method is now tested ( and fixed).
> org.apache.mina.codec.IoBuffer#mark is untested and broken
> ----------------------------------------------------------
>
> Key: DIRMINA-950
> URL: https://issues.apache.org/jira/browse/DIRMINA-950
> Project: MINA
> Issue Type: Bug
> Affects Versions: 3.0.0-M1
> Reporter: Esko Luontola
> Fix For: 3.0.0-trunk
>
>
> Currently the org.apache.mina.codec.IoBuffer#mark method sets the limit
> instead of the mark, which is different from java.nio.Buffer#mark.
> Also IoBuffer has disturbingly low code coverage: 87% method and 77% line
> coverage according to IntelliJ IDEA. IoBuffer's such a central class, that I
> would expect it to have 100% mutation coverage (see http://pitest.org/).
> There are even a bunch of methods that are never used: arrayOffset(),
> asReadOnlyBuffer(), mark(), reset().
> I've found http://pitest.org/ to be very useful in finding untested code. I
> warmly recommend trying it out. Setting it up is this easy:
> https://github.com/orfjackal/jumi/blob/80a394a5832eb90f7302f30c912b7486122b9e4c/parent/pom.xml#L455-L490
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
