[jira] [Created] (DIRMINA-984) Sftplet.onConnect(...) does not obtain access to ServerSession

[Dmitri Priimak (JIRA)]

Dmitri Priimak created DIRMINA-984:
--------------------------------------

             Summary: Sftplet.onConnect(...) does not obtain access to 
ServerSession
                 Key: DIRMINA-984
                 URL: https://issues.apache.org/jira/browse/DIRMINA-984
             Project: MINA
          Issue Type: Bug
            Reporter: Dmitri Priimak


Using Sftplet I encountered one small problem. 
In current git repo in file

sshd-sftp/src/main/java/org/apache/sshd/sftp/subsyste/SftpSubsystem.java

in lines 138 through 141 there is following code

public void setSession(ServerSession session) {
    sftpLet.onConnect(this);
    this.session = session;
}

This calls sftpLet.onConnect(...) before session is set, which means that at 
that stage information from the session such as user name of the 
person who logged in or the remote ip address is not available in inside of 
onConnect(...) call even though ServerServer already has this information.

A simple swapping of just two lines should fix that, like so

public void setSession(ServerSession session) {
    this.session = session;
    sftpLet.onConnect(this);
}

Can such change be made in your code?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)