[
https://issues.apache.org/jira/browse/SSHD-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276786#comment-14276786
]
Goldstein Lyor edited comment on SSHD-401 at 1/14/15 11:03 AM:
---------------------------------------------------------------
This is the diff file to be applied *after* SSHD-395 has been applied. The code
is in the form of a _.diff_ file since attempting to apply both SSHD-395 and
this one would cause conflicts.
*Note*: I added a *minimum* buffer size check (currently ~127 bytes) as IMO we
want to prevent users from using buffers that are too small. If you disagree,
simply set _ScpHelper#MIN_COPY_BUFFER_SIZE_ to zero - thus leaving the option
to restore this feature if you decide to do so some time in the future.
was (Author: lgoldstein):
This is the diff file to be applied *after* SSHD-395 has been applied. The code
is in the form of a _.diff_ file since attempting apply both SSHD-395 and this
one would cause conflicts.
*Note*: I added a *minimum* buffer size check (currently ~127 bytes) as IMO we
want to prevent users from using buffers that are too small. If you disagree,
simply set _ScpHelper#MIN_COPY_BUFFER_SIZE_ to zero - thus leaving the option
to restore this feature if you decide to do so some time in the future.
> Allow user control over ScpCommand send/receive buffer size
> -----------------------------------------------------------
>
> Key: SSHD-401
> URL: https://issues.apache.org/jira/browse/SSHD-401
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 0.14.0
> Reporter: Goldstein Lyor
> Priority: Minor
> Attachments: SSHD-395-to-401.diff
>
>
> While 8192 is a good rule-of-thumb value for I/O buffering, IMO we should
> allow users to fine-tune it to their needs. Attached is a patch suggestion.
> *Note*: the patch also optimizes the allocated I/O buffer by taking into
> consideration the *size* of the file it is expecting to send/receive
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
