[
https://issues.apache.org/jira/browse/SSHD-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316140#comment-14316140
]
Goldstein Lyor commented on SSHD-401:
-------------------------------------
I don't think so - I believe that specific settings are clearer - in this
context see SSHD-407 patch that I posted. Also, passing customization
parameters through the _FactoryManager_ is not type-safe - one has to use an
"oral" agreement between the code that sets the parameter and the one the uses
it. In our case, what if instead of an _ExecutorService_ we decide to use an
_Executor_ ? The user's code will compile as before, but at runtime it will
fail with _ClassCastException_. This way, if we change a type, the user's code
will fail to compile and the change will be easier to catch and manage.
> Allow user control over ScpCommand send/receive buffer size
> -----------------------------------------------------------
>
> Key: SSHD-401
> URL: https://issues.apache.org/jira/browse/SSHD-401
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 0.14.0
> Reporter: Goldstein Lyor
> Assignee: Guillaume Nodet
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: SSHD-395-to-401.diff
>
>
> While 8192 is a good rule-of-thumb value for I/O buffering, IMO we should
> allow users to fine-tune it to their needs. Attached is a patch suggestion.
> *Note*: the patch also optimizes the allocated I/O buffer by taking into
> consideration the *size* of the file it is expecting to send/receive
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
