I've pushed a private branch to upgrade to mina 3 (link in https://issues.apache.org/jira/browse/SSHD-418). Tests do pass, however, I have a few remarks / suggestions: * close methods not available on any interface for NioTcpClient / NioTcpServer * the bound address is not easily available: when binding to port 0, you need to use server.getServerSocketChannel().getLocalAddress() * backlog socket configuration not supported
Also, what's the envisioned timeframe for 3.0 ? 2015-02-23 17:59 GMT+01:00 Guillaume Nodet <[email protected]>: > So 1.0 does not include the old file access api, it has been completely > switched to NIO2 FileSystem api for that. > For sockets, NIO.1 is supported through mina core 2.0.8. I think what > you're > suggesting is to upgrade to mina 3.0 for sshd 1.0, right ? > If so, I do agree... > > > 2015-02-23 17:39 GMT+01:00 Emmanuel Lécharny <[email protected]>: > >> Le 23/02/15 17:17, Guillaume Nodet a écrit : >> > So the NIO2 FileSystem api is only used for sftp / scp support. >> > I'd like to avoid supporting both filesystems api long term, but I >> > don't rule out bug fixing releases on 0.14.x so that users can >> > migrate to 1.0 at their own pace. >> The question is more about which version supports what. >> >> If 0.14 is for NIO.1 and 1.0 is for NIO.2, then the signal is not clear >> for users. >> >> Either we stop supporting NIO.1, and switch completely to NIO.2 (which >> would make sense considering Java 6 is long dead), then sshd 1.0 should >> be the right number. Or we keep going with NIO.1, and then maybe 2 >> versions for SSHd are needed : sshd 1.0 for NIO.1 and sshd 2.0 for NIO.2. >> >> wdyt ? >> >> >
